Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add escape/unescape per http://nodejs.org/api/querystring.html #7

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link

@Trott Trott commented Oct 4, 2014

add escape() and unescape() + minimal tests to show that they work as expected and (per the NodeJS documentation) can be overridden

This issue has been mentioned at:
#6
mike-spainhower#4
browserify/browserify#826

@medikoo
Copy link
Collaborator

medikoo commented Mar 1, 2015

@Trott Browserify relies on querystring-es3, so any fix here wouldn't fix issue over there.

Also discussion about inconsistency with node is handled now at #6

@mike-spainhower
Copy link

I will happily merge updates from this repo into https://github.com/mike-spainhower/querystring if they happen to be ES3 compatible. Anything incompatible would be handled separately via issue or PR in the fork.

@dy
Copy link

dy commented May 27, 2015

This issue seems to have long consequences, see mike-spainhower#4

@medikoo
Copy link
Collaborator

medikoo commented May 27, 2015

@dfcreative issue you meantion is about querystring-es3 (not this project) being incompatible with node. querystring-es3 is different project maintained by different person.

@dy
Copy link

dy commented May 27, 2015

@medikoo the owner refers to your repository as a source of incompatibility

@medikoo
Copy link
Collaborator

medikoo commented May 27, 2015

@dfcreative owner then should rely on Node.js and not this package

@medikoo
Copy link
Collaborator

medikoo commented May 27, 2015

@dfcreative incompatibility discussion you linked, is actually a different matter, and it's not related to how querystring natively works in Node.js, it's about incompatibility with one of the goals of Browserify, read carefully linked issue.

@ceremcem
Copy link

...and I think this issue is related with this pull request too.

balu- pushed a commit to balu-/webdav-client that referenced this pull request Jan 1, 2017
@nickpeihl
Copy link

If we ignore the incompatibilities with Browserify, is there anything that is keeping this from being merged?

@SpainTrain
Copy link

FWIW I just updated the es3-compatible version and will be publishing it shortly behind a major bump - https://github.com/SpainTrain/querystring-es3

Feel free to review and flag any issues.

@medikoo
Copy link
Collaborator

medikoo commented Apr 11, 2017

See proposed roadmap: #20 it covers also ES3 version, PR's are very welcome (and I will handle them promptly).

I'm going to close it as it all should be addressed with new published versions

@medikoo medikoo closed this Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants